Fix NumPy 2.x compatibility: replace np.string_ with np.bytes_
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy v2.0 removed `np.string_` from the API and recommended using `np.bytes_` instead. I checked the other API removals in the NumPy v2.0 change log and didn't see any instances of removed objects in the nexusformat codebase. See https://numpy.org/doc/stable/release/2.0.0-notes.html for more info.
|
Thanks for the heads-up about NumPy 2.0. It doesn't seem to be available in my conda distribution, but after updating with pip, the pytest does indeed throw up a lot of errors, which your changes fix. Since you have created this PR, please could you add a fix to prevent another deprecation warning. The call signature for the It's on line 3283 of my version of |
For NumPy 2.0 compatibility.
|
I updated the |
|
@Z2h-A6n, thanks for the PR. |
|
No problem, thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy v2.0 removed
np.string_from the API and recommended usingnp.bytes_instead, so I made that change. Sincenp.string_was already an alias fornp.bytes_, I think this is backward compatible with recent versions Numpy v1.x. At least test suite passes with both NumPy 2.0.0 and NumPy 1.26.4.I checked the other API removals in the NumPy v2.0.0 release notes and didn't see any other instances of removed NumPy objects in the nexusformat codebase.
Without this change, some of my previously-working code that checked for certain entries in a
nxs.tree.NXdata.attrsdictionary was failing.